Skip to content

Conversation

@oliveromahony
Copy link
Contributor

Proposed changes

Update the dynamic config file with the features received in the AgentDetails message. Proposed list of features planned to be supported:

  • registration
  • nginx-config
  • nginx-ssl-config
  • nginx-counting
  • metrics (core)
  • metrics-throttle
  • dataplanestatus
  • process-watcher
  • file-watcher
  • activity-events

These changes will be used to support feature toggling where different use cases are enabled/disabled based on the feature list either in the nginx-agent.conf file or through the Proto Command populating the AgentDetails message.
For example, a client can opt out of uploading their nginx-config or the ssl information present in their nginx-config

This initial PR will focus on nginx-config and nginx-ssl-config use cases.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@github-actions github-actions bot added dependencies enhancement New feature or request labels Aug 24, 2022
@oliveromahony oliveromahony changed the title added features key to config to list features for NGINX Agent WIP: added features key to config to list features for NGINX Agent Aug 24, 2022
@oliveromahony oliveromahony changed the title WIP: added features key to config to list features for NGINX Agent added features key to config to list features for NGINX Agent Aug 25, 2022
@oliveromahony oliveromahony merged commit 87f8d80 into main Aug 29, 2022
@oliveromahony oliveromahony deleted the features branch August 29, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants